[Openchrome-users] XAA SolidFillRect problem with negative x value

[Benno Schulenberg]

Thomas Hellstr?m wrote:
> Benno Schulenberg wrote:
> > If negative, then I'd think that it's at least also an
> > application error, because, when fullscreen, how can it have a
> > negative x?
>
> It may also be a sign bug in the driver.

Hmm, I don't see how.  The negative x coordinates reported by Mark 
are produced by OO Writer, aren't they?  The XAA routines are not 
indirectly called by the driver itself, or are they?

> I'm not sure whether the hardware can cope with negative x values
> but if it can, they definitely need to be masked, since they only 
> occupy 16 bits:
>
> x &= 0xFFFF;

Okay, see the proposed patch.  It also adds warnings when negative 
clipping or rectangle values occur, as I'd like to know whether this 
occurs more often or is entirely seldom.

Benno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xopen--negative-values.patch
Type: text/x-diff
Size: 980 bytes
Desc: not available
Url : http://wiki.openchrome.org/pipermail/openchrome-users/attachments/20070215/5dc342e5/xopen--negative-values.bin