[Openchrome-users] MPlayer VLD XvMC patch question.

[Tim Phipps]

Hi,
	I have MPlayer-1.0rc1 and have applied the patch to go with it, all is fine 
except I can no longer give more than three files on the command line for 
mplayer to play. I think the problem is this section of the patch:

@@ -1183,7 +1243,13 @@
 static void uninit(void){
    if( mp_msg_test(MSGT_VO,MSGL_DBG4) ) {
       printf("vo_xvmc: uninit called\n"); }
-   xvmc_free();
+   //
+   // This function can be called as part of a signal handler, and
+   // calling xvmc_free() thus may result in a deadlock.
+   // Don't do it this way.
+   // The xvmc subsystem should take care of this anyway.
+   //
+   // xvmc_free();


If I miss out this part of the patch, mplayer happily plays more than three, 
my offspring can happily watch twenty minutes of Noddy episodes while having 
breakfast, and all is well with the world.

The comment scares me but xvmc_free() is static in libvo/vo_xvmc.c, so I'm not 
sure how it could be used in a signal handler.

Am I doing the right thing?

Cheers,
Tim.