[Openchrome-users] [Openchrome-devel] Fwd: [PATCH] drm via: initialize object_idr

James Simmons jsimmons
Tue Jun 19 16:51:24 PDT 2012


> From: M?rton N?meth <nm127 at freemail.hu>
> 
> The field obejct_idr of struct drm_via_private was introduced with the
> commit http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=77ee8f3825054f23b17e9c8f728f061defd86cdc .
> In that patch idr_init(&dev->object_name_idr) was called instead of
> idr_init(&dev_priv->object_idr) by mistake, leaving the dev_priv->object_idr
> uninitialized. To be more exact, the object_idr buffer is filled with zeros
> because of kzalloc(), but the dev_priv->object_idr.lock spinlock can cause
> system freeze at lib/idr.c:move_to_free_list() when spin_lock_irqsave()
> is called on this spinlock.

Thank you for the patch. I tested it on my systems and had no regressions. 
I sent the patch off to the DRI list to be merged.



More information about the Openchrome-users mailing list