be less verbose on non-errors

Stef Walter stefw at redhat.com
Mon Jun 30 04:52:34 PDT 2014


On 27.06.2014 17:26, Nikos Mavrogiannopoulos wrote:
> This patch makes p11-kit a bit less verbose.

-		if (rv != CKR_OK) {
+		if (rv != CKR_OK && rv != CKR_CRYPTOKI_ALREADY_INITIALIZED) {

Thanks for the patch, but wouldn't this cause problems when
p11_kit_modules_finalize() (or another C_Finalize invocation) is called,
and the module would be finalized too many times?

Where did you see this happen? Was the module loaded with the
P11_KIT_UNMANAGED flag? The goal is that when modules are managed by
p11-kit they never return that error code.

Cheers,

Stef



More information about the p11-glue mailing list