libtasn1 CFLAGS problems once again

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Oct 6 08:55:12 PDT 2014


  Roman Bogorodskiy wrote:

>   Stef Walter wrote:
> 
> > On 05.10.2014 17:36, Roman Bogorodskiy wrote:
> > > Hi,
> > > 
> > > There was a problem with not properly passing libtasn1 CFLAGS for some
> > > targets that was fixed and now it looks like it's there again.
> > > 
> > > Making all in .
> > > gmake[2]: Entering directory `/usr/home/novel/code/p11-kit'
> > >   CC       trust/asn1.lo
> > > In file included from trust/asn1.c:37:
> > > trust/asn1.h:35:10: fatal error: 'libtasn1.h' file not found
> > > #include <libtasn1.h>
> > >          ^
> > > 1 error generated.
> > > gmake[2]: *** [trust/asn1.lo] Error 1
> > > 
> > > I have attached a patch that fixes this problem for me. I'm not it's
> > > done in an optimal way, that's why I didn't spend time preparing a
> > > commit with the commit message. The reason of my doubt that there's
> > > quite an amount of copy/paste that probably could be fixed somehow so
> > > the libtasn1 flags could be passed in some single place.
> > 
> > Interesting. Thanks for the patch. It doesn't apply to either the master
> > or stable p11-kit git branches. Which version of p11-kit does it apply to?
> 
> That should be against the master branch, maybe I forgot to pull before
> though...
> 
> I'll double check later today.

Yeah, the patch was against current master branch (I was able to apply
it with 'patch -p1'). 

Attaching a patch that works with 'git apply'.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: p11-kit-libtasn1-cflags_2reroll.patch
Type: text/x-diff
Size: 4118 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/p11-glue/attachments/20141006/b5cf918d/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/p11-glue/attachments/20141006/b5cf918d/attachment.sig>


More information about the p11-glue mailing list