segv in p11_array_push

[Daiki Ueno]

Patrick Welche <prlw1 at cam.ac.uk> writes:

>   https://mail-index.netbsd.org/tech-userlevel/2015/02/05/msg008912.html
>
> that the obfuscation is to encourage reallocarr(3) instead. The point
> is that as reallocarray is in libc, it always will be, and AC_CHECK_LIBS
> will always find it.

Thank you for the information, that explains the issue.

> I suppose I could make a AC_CHECK_LIBS(reallocarr) patch for you, and
> use that if found, else use reallocarray. What do you think?

I am not sure if it's worth using reallocarr instead, to be honest.

It is meant for fixing a slight corner case which p11-kit doesn't care,
and is currently only available on NetBSD, while reallocarray is
available on glibc systems and FreeBSD.

So instead, I have filed a PR which adds an extra check on the function
declaration:
https://github.com/p11-glue/p11-kit/pull/176

Regards,
-- 
Daiki Ueno