[packagekit] packagekit: Branch 'master'

Tom Parker palfrey at tevp.net
Fri Aug 31 12:47:47 PDT 2007


Richard Hughes wrote:
> On 31/08/2007, Richard Hughes <hughsient at kemper.freedesktop.org> wrote:
>>  src/pk-task-apt.cpp |  122 ++++++++++++++++++++++++++++++++++++++++++++++++++--
>>  1 file changed, 119 insertions(+), 3 deletions(-)
>> +               pk_task_error_code(task, PK_TASK_ERROR_CODE_INTERNAL_ERROR, "can't allocate memory for search task");
> 
> I think we need to add the error enum PK_TASK_ERROR_CODE_OOM. Are
> there any others I should add while I'm there?

The other internal error case in there is "we wanted a thread and 
couldn't get one". I'd be asking for a new error code, but given that 
most of the cases where that actually happens tend to be of the "you 
need to reboot" variety, I think that INTERNAL_ERROR covers it well 
enough. OTOH, maybe we may need to distinguish between those and the 
cases where the backend packaging system is completely screwed and needs 
someone to have a better look at it. PACKAGE_SYSTEM_FAILURE?

Tom



More information about the PackageKit mailing list