[packagekit] Export GROUP_UNKNOWN to backends

[Tim Lauridsen]

Richard Hughes wrote:
> On Wed, 2007-10-31 at 17:33 +0200, S.Çağlar Onur wrote:
>   
>> commit 26d69ac6757dd14742ad51ce70dd0649db033d8f
>> Author: S.Çağlar Onur <caglar at pardus.org.tr>
>> Date:   Wed Oct 31 17:13:45 2007 +0200
>>
>>     export GROUP_UNKNOWN to backends
>>
>> diff --git a/python/packagekit/backend.py b/python/packagekit/backend.py
>> index f2e8ae5..6495f63 100644
>> --- a/python/packagekit/backend.py
>> +++ b/python/packagekit/backend.py
>> @@ -97,6 +97,7 @@ GROUP_FONTS             = "fonts"
>>  GROUP_ADMIN_TOOLS       = "admin-tools"
>>  GROUP_LEGACY            = "legacy"
>>  GROUP_LOCALIZATION      = "localization"
>> +GROUP_UNKNOWN           = "unknown"
>>     
>
> Sane.
>
>   
>> But instantly this question triggered in my mind. Do we have to map all groups 
>> to known ones? If not, following one also needed by PK-Gnome but this means 
>> group list will start to show a group called "Unknown" to users.
>>
>> What should i do (revert the above or pushing following)?
>>
>> diff --git a/src/pk-common-gui.c b/src/pk-common-gui.c
>> index 6226c16..d898b0d 100644
>> --- a/src/pk-common-gui.c
>> +++ b/src/pk-common-gui.c
>> @@ -641,6 +641,9 @@ pk_group_enum_to_localised_text (PkGroupEnum group)
>>  	case PK_GROUP_ENUM_LOCALIZATION:
>>  		text = _("Localization");
>>  		break;
>> +	case PK_GROUP_ENUM_UNKNOWN:
>> +		text = _("Unknown");
>> +		break;
>>  	default:
>>  		pk_error ("group unrecognised: %i", group);
>>  	}
>>     
>
> Push this, as it should be there anyway - but i don't think we should
> show an "unknown" in pk-application - maybe we can just special case it.
>
> Richard.
>
>
> _______________________________________________
> PackageKit mailing list
> PackageKit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/packagekit
>   
Do we need a GROUP_UNKNOWN ???

Uncategorised packages should go into GROUP_OTHER or in no groups at all

Tim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20071101/c63c58ff/attachment-0004.htm>