[packagekit] [PATCH] PK_GROUP_ENUM_POWERMANAGEMENT

[Richard Hughes]

On Fri, 2007-11-02 at 13:37 +0200, S.Çağlar Onur wrote:
> If there is no objection i'll commit following to PK to add a powermanagement 
> group which holds powermanagement related goodies like 
> kpowersave/gnome-powersave/acpi/acpid/powertop/suspend/pm-tools and others

Pet peeve. Power management is two words. Trust me :-)

> diff --git a/libpackagekit/pk-enum.c b/libpackagekit/pk-enum.c
> index 14956c1..298e21f 100644
> --- a/libpackagekit/pk-enum.c
> +++ b/libpackagekit/pk-enum.c
> @@ -146,6 +146,7 @@ static PkEnumMatch enum_group[] = {
>  	{PK_GROUP_ENUM_LEGACY,			"legacy"},
>  	{PK_GROUP_ENUM_LOCALIZATION,		"localization"},
>  	{PK_GROUP_ENUM_VIRTUALIZATION,		"virtualization"},
> +	{PK_GROUP_ENUM_POWERMANAGEMENT,		"powermanagement"},

{PK_GROUP_ENUM_POWER_MANAGEMENT, "power-management"},

>  	PK_GROUP_ENUM_UNKNOWN
>  } PkGroupEnum;
>  
> diff --git a/python/packagekit/backend.py b/python/packagekit/backend.py
> index e0285ef..4676e37 100644
> --- a/python/packagekit/backend.py
> +++ b/python/packagekit/backend.py
> @@ -99,6 +99,7 @@ GROUP_LEGACY            = "legacy"
>  GROUP_LOCALIZATION      = "localization"
>  GROUP_VIRTUALIZATION    = "virtualization"
>  GROUP_SECURITY          = "security"
> +GROUP_POWERMANAGEMENT   = "powermanagement"

Same :-)

>  GROUP_UNKNOWN           = "unknown"
>  
>  # Classes
> 
> and PK-Gnome (again i cannot select the icon name :))
> 
> diff --git a/src/pk-common-gui.c b/src/pk-common-gui.c
> index cf4580a..5259e66 100644
> --- a/src/pk-common-gui.c
> +++ b/src/pk-common-gui.c
> @@ -114,6 +114,7 @@ static PkEnumMatch enum_group_icon_name[] = {
>  	{PK_GROUP_ENUM_LOCALIZATION,		"preferences-desktop-locale"},
>  	{PK_GROUP_ENUM_VIRTUALIZATION,		"computer"},
>  	{PK_GROUP_ENUM_SECURITY,		"network-wireless-encrypted"},
> +	{PK_GROUP_ENUM_POWERMANAGEMENT,		"network-wireless-encrypted"},

"battery" is a good icon for this I think.

Don't worry about adding and removing groups like we are doing; this is
actually what I wanted. I always thought we would evolve the group list
to a good common abstraction. And it's working ;-)

Thanks,

Richard.