[packagekit] Compilation error

[Richard Hughes]

On Thu, 2007-10-11 at 00:22 +0200, Matej Cepl wrote:
> On 2007-10-10, 16:17 GMT, Richard Hughes wrote:
> > On Wed, 2007-10-10 at 15:42 +0200, Adrien BUSTANY wrote:
> >> Reading the code I don't even understand how this code could work...
> >> Casting a boolean to a GMainLoop is black voodoo to me. Maybe you should
> >> replace the gboolean by gpointers in the function's prototype, but I'm
> >> not sure.
> >
> > Correct, I've just committed that fix - sorry about that. I must have
> > coded that when I was half-asleep! Can you try rebuilding now please.
> > Thanks.
> 
> With couple more of these I was able to build the package on 
> x86_64 (not real testing though, I am connected to the box via 
> ssh; it is also on 
> http://www.ceplovi.cz/matej/progs/rpms/gnome-packagekit-MCfix.patch 
> in case slrn screws up the inline patch):

Applied to git and pushed to fd.o, thanks.

> pk-application.c:1097: warning: implicit declaration of function 
> 'pk_enum_list_size'
> pk-application.c:1099: warning: implicit declaration of function 
> 'pk_enum_list_get_item'

You need to make sure you have the current PackageKit-devel files
installed when you build gnome-packagekit; pk_enum_get_item was only
added to libpackagekit a few days ago.

> When doing package for Fedora I have run it through rpmlint as 
> well and fixed all outstanding problems so that both src.rpm and 
> x86_64.rpm are rpmlint-silent. Here is the patch of SPEC file 
> (again, also on http://www.ceplovi.cz/matej/progs/rpms\
> /gnome-packagekit-spec.diff):

Cool thanks. I run autobuild to generate my rpms from git, so I'll apply
your patch the best I can. The rpm's in utopia are always a little rough
and ready :-)

> --- /home/matej/rpm/SPECS/gnome-packagekit.spec.orig	2007-10-10 23:24:03.000000000 +0200
> +++ /home/matej/rpm/SPECS/gnome-packagekit.spec	2007-10-10 23:42:39.000000000 +0200
> @@ -5,18 +5,18 @@
>  Name: gnome-packagekit
>  Version: 0.0.1
>  Release: 0.128%{?alphatag}%{?dist}
> -License: GPL
> +License: GPLv2+

Is this true? Are the new bits of the apt backend GPL2 only?

> -%{_sysconfdir}/gconf/schemas/*.schemas
> +%config(noreplace)%{_sysconfdir}/gconf/schemas/*.schemas

Are you sure? What if I add new keys to the schema?

Thanks,

Richard.