[packagekit] [RFC] Remove "/" from pk_validate_input_char

S.Çağlar Onur caglar at pardus.org.tr
Tue Oct 30 02:28:06 PDT 2007


I'm trying to implement search-file support to PiSi backend but while i'm on it, i realize pk_validate_input_char won't let me input full paths as search terms like following.

caglar at zangetsu ~ $ pkcon search file /usr/kde/3.5/bin/kopete
installed    kdenetwork           Any     3.5.8-37-30                  KDE network apps: kopete, kppp, kget
search-file runtime was 0.6 seconds

caglar at zangetsu ~ $ pkcon search file /bin/ls
installed    coreutils            Any     6.9-24-20                    Standard GNU file, text and shell utilities
search-file runtime was 0.5 seconds

Is it OK to push following to solve this problem, if not what is your suggestions?

diff --git a/libpackagekit/pk-common.c b/libpackagekit/pk-common.c
index 0898986..6d73f1c 100644
--- a/libpackagekit/pk-common.c
+++ b/libpackagekit/pk-common.c
@@ -132,7 +132,6 @@ pk_validate_input_char (gchar item)
 	case '}':
 	case '@':
 	case '#':
-	case '/':
 	case '\\':
 	case '<':
 	case '>':

S.Çağlar Onur <caglar at pardus.org.tr>

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20071030/bda83545/attachment-0004.pgp>

More information about the PackageKit mailing list