[packagekit] Export GROUP_UNKNOWN to backends

S.Çağlar Onur caglar at pardus.org.tr
Wed Oct 31 08:33:27 PDT 2007


Hi;

I just committed following to PK

commit 26d69ac6757dd14742ad51ce70dd0649db033d8f
Author: S.Çağlar Onur <caglar at pardus.org.tr>
Date:   Wed Oct 31 17:13:45 2007 +0200

    export GROUP_UNKNOWN to backends

diff --git a/python/packagekit/backend.py b/python/packagekit/backend.py
index f2e8ae5..6495f63 100644
--- a/python/packagekit/backend.py
+++ b/python/packagekit/backend.py
@@ -97,6 +97,7 @@ GROUP_FONTS             = "fonts"
 GROUP_ADMIN_TOOLS       = "admin-tools"
 GROUP_LEGACY            = "legacy"
 GROUP_LOCALIZATION      = "localization"
+GROUP_UNKNOWN           = "unknown"
 
 # Classes
 
But instantly this question triggered in my mind. Do we have to map all groups 
to known ones? If not, following one also needed by PK-Gnome but this means 
group list will start to show a group called "Unknown" to users.

What should i do (revert the above or pushing following)?

diff --git a/src/pk-common-gui.c b/src/pk-common-gui.c
index 6226c16..d898b0d 100644
--- a/src/pk-common-gui.c
+++ b/src/pk-common-gui.c
@@ -641,6 +641,9 @@ pk_group_enum_to_localised_text (PkGroupEnum group)
 	case PK_GROUP_ENUM_LOCALIZATION:
 		text = _("Localization");
 		break;
+	case PK_GROUP_ENUM_UNKNOWN:
+		text = _("Unknown");
+		break;
 	default:
 		pk_error ("group unrecognised: %i", group);
 	}

Cheers
-- 
S.Çağlar Onur <caglar at pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20071031/e7a6d243/attachment-0004.pgp>


More information about the PackageKit mailing list