[packagekit] packagekit: Branch 'master' - 2 commits

[Richard Hughes]

On 10/09/2007, Richard Hughes <hughsient at kemper.freedesktop.org> wrote:
> +gboolean
> +pkg_equal (pmpkg_t *p1, pmpkg_t *p2)
> +{
> +  if (strcmp (alpm_pkg_get_name (p1), alpm_pkg_get_name (p2)) != 0)
> +    return FALSE;
> +  if (strcmp (alpm_pkg_get_version (p1), alpm_pkg_get_version (p2)) != 0)
> +    return FALSE;
> +  return TRUE;
> +}

You need to use tabs for indentation, set to 8-space size. I would
prefer if you could stick to the exiting formatting too, e.g.

if (foo) {
<tab>bar ();
}

+/**
+ * backend_get_depends:
+ */
+static void
+backend_get_depends (PkBackend *backend, const gchar *package_id)
+{
+       g_return_if_fail (backend != NULL);
+       pk_backend_package (backend, 1, "glib2;2.14.0;i386;fedora",
+                        "The GLib library");
+       pk_backend_package (backend, 1, "gtk2;gtk2-2.11.6-6.fc8;i386;fedora",
+                        "GTK+ Libraries for GIMP");
+       pk_backend_finished (backend, PK_EXIT_ENUM_SUCCESS);
+}

Please do not do this. If the method is not working yet then please
set the get_depends entry in the init struct to NULL, and not just
copy the dummy code. The alpm backend should *only* have the code
which it natively supports.

Thanks.

Richard.