[packagekit] Please check git

Richard Hughes hughsient at gmail.com
Mon Sep 10 10:07:00 PDT 2007


On 10/09/2007, Tom Parker <palfrey at tevp.net> wrote:
> Richard Hughes wrote:
> > Ahh, good idea. We can try ../backends/$backend/*.so first, and then
> > try the /usr/lib location. I can give this a go this afternoon if you
> > like.
>
> Haven't seen any work on this (not surprising given your mammoth TODO!),
> so I had a quick go myself. Patch is attached.
>
> Comments?

+	path = g_build_filename
("..","backends",backend->priv->name,".libs", filename, NULL);
+	if (!g_file_test(path,G_FILE_TEST_EXISTS))
+	{
+		g_free(path);
+		path = g_build_filename (LIBDIR, "packagekit-backend", filename, NULL);
+	}

You need to stick to the style guideline - I've turned a blind eye in
the C++ backend as it's, well, C++ and not C, but this bit is
important :-)

i.e.

	path = g_build_filename ("..", "backends", backend->priv->name,
".libs", filename, NULL);
	if (g_file_test (path, G_FILE_TEST_EXISTS) == FALSE) {
		g_free(path);
		path = g_build_filename (LIBDIR, "packagekit-backend", filename, NULL);
	}

is what you want.

> Tom
>
> P.S. Private git server appears to be down (current IP from my end, even
> after querying nf1.no-ip.com directly is 86.132.118.61)

Urgh, no-ip sucks at the moment. I'll try and get git.packagekit.org
sorted as soon as Ken gets the colo organised. The IP is 86.158.149.35

Richard.



More information about the PackageKit mailing list