[packagekit] set backend name in pk_backend_set_name

Stefan Haas shaas at suse.de
Wed Apr 2 08:32:23 PDT 2008


Richard Hughes schrieb:
> On Wed, 2008-04-02 at 15:14 +0200, Stefan Haas wrote:
>   
>> in the commit "correct some error handling in pk_backend_set_name"
>> today a few necessary lines of code were deleted:
>> If it was intention we've to set the name of the backend otherwise...
>>     
>
> In 15ab5bef458e046fb5884d0cfc59c66f4f97ed65 I changed this to:
>
> 	/* save the backend name and handle */
> 	g_free (backend->priv->name);
> 	backend->priv->name = g_strdup (backend_name);
> 	backend->priv->handle = handle;
>
> only if we didn't hit any if the error checks. Doesn't this do the same
> job?
>
> Richard.
>
>
> _______________________________________________
> PackageKit mailing list
> PackageKit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/packagekit
>   
The problem is that the name is already needed in
pk_backend_build_library_path. In the current state it'll fail with

** (lt-packagekitd:7350): CRITICAL **: pk_backend_build_library_path:
assertion `backend->priv->name != NULL' failed
(at least with the zypp and dummy backend)

Stefan



More information about the PackageKit mailing list