[packagekit] [PATCH]Service Packs: Creation and Installation

Richard Hughes hughsient at gmail.com
Fri Aug 15 08:33:50 PDT 2008

On Fri, 2008-08-15 at 17:36 +0530, Shishir Goyal wrote:
> Added a new file pk-generate-pack-main.c and test cases to pkgenpack.
> Patches Attached. Reviews awaited!

I've applied both patches, thanks. The test case does however appear to
be leaking memory like mad - for instance you're not unreffing the
PkClient instance you're using -- or freeing the file lists.

BUT. You've done wonderous things for this GSoC -- PackageKit is a
formidable code base and you've don really well understanding it. I'm
just a fussy git!


More information about the PackageKit mailing list