[packagekit] [PATCH]Service Packs: Creation and Installation

[Richard Hughes]

On Tue, 2008-07-29 at 22:41 +0530, Shishir Goyal wrote:
> I have tried making a service pack generator to create the service
> packs and then installing them using InstallFile.
> These are the few patches I have come up with.
> 
> http://fpaste.org/paste/4101

I've reformatted this to not leak memory and to be a bit more modular,
but otherwise the concept was okay. I've pushed it to git master.

> http://fpaste.org/paste/4102

Ahh, I've found the bug -- I wrote:

is_local = g_file_test (packages[i], G_FILE_TEST_EXISTS & G_FILE_TEST_IS_REGULAR);

when really I meant:

is_local = g_file_test (packages[i], G_FILE_TEST_EXISTS | G_FILE_TEST_IS_REGULAR);

> http://fpaste.org/paste/4103

I've applied this with a small tweak.

> http://fpaste.org/paste/4104

I don't need this one -- are you sure the PolicyKit stuff is setup
correctly? There's also a load of FIXME's in the new code, you should
probably look at fixing them. Otherwise, things look good, well done.

Richard.