[packagekit] Allowing multiple actions in a transaction

Robin Norwood rnorwood at redhat.com
Mon Mar 10 12:09:38 PDT 2008


On Mon, 10 Mar 2008 00:45:15 +0000
Richard Hughes <hughsient at gmail.com> wrote:

> On Sun, 2008-03-09 at 20:03 +0000, Richard Hughes wrote:
> > We'll do this API break slowly, as I appreciate it's a large
> > internal and external API change that great potential to go
> > wrong. ;-)
> 
> Well, just for one method (UpdatePackages) this is the diffstat:
> 
>  backends/dummy/pk-backend-dummy.c       |   16 ++++++--
>  backends/test/pk-backend-test-dbus.c    |    2 -
>  backends/test/pk-backend-test-fail.c    |    6 +--
>  backends/test/pk-backend-test-succeed.c |    6 +--
>  backends/yum/pk-backend-yum.c           |   14 +++++--
>  backends/yum2/pk-backend-yum2.c         |    8 ++--
>  client/pk-console.c                     |    2 -
>  libpackagekit/pk-client.c               |   59
> ++++++++++++++++++++++++--------
> libpackagekit/pk-client.h               |    7 ++-
> src/pk-backend-dbus.c                   |   10 ++---
> src/pk-backend-dbus.h                   |    4 +-
> src/pk-backend.h                        |    6 +--
> src/pk-engine.c                         |   25 +++++--------
> src/pk-engine.h                         |    4 +-
> src/pk-interface.xml                    |    4 +-
> src/pk-runner.c                         |   18 +++++----
> src/pk-runner.h                         |    4 +- 17 files changed,
> 122 insertions(+), 73 deletions(-)
> 
> So, not a disaster. I've not even tried to convert the other backends,
> as this is just proof of concept, but the attached patch shows what I
> had to do. Nothing is in git yet. Comments welcome.

I think this is ok.  I'll try to get the yum backend(s) using this if
you commit it.

-RN

-- 
Robin Norwood
Red Hat, Inc.

"The Sage does nothing, yet nothing remains undone."
-Lao Tzu, Te Tao Ching



More information about the PackageKit mailing list