[packagekit] Make check problem with QPackageKit

Richard Hughes hughsient at gmail.com
Mon Nov 24 07:24:32 PST 2008


On Mon, 2008-11-24 at 11:32 +0000, Richard Hughes wrote:
> Hey,
> 
> Your last commit has triggered a "make check" failure. I'm about to do
> the release, so we need to fix this really quickly:
> 
> removing transaction from pool :  "/729_ebdcaacd_data" 
> .......F...
> 
> !!!FAILURES!!!
> Test Results:
> Run:  10   Failures: 1   Errors: 0
> 
> 1) test: TransactionTest::resolveAndInstallAndRemove (F) line: 39
> transactiontest.cpp
> assertion failed
> - Expression: t != NULL
> - installPackages
> 
> Please can you debug what the regression is please, or I'll have to
> revert your patch for the release.

Grrr. Make distcheck fails too:

../../../../lib/packagekit-qt/src/polkitthread.cpp:1:37: error: polkit-dbus/polkit-dbus.h: No such file or directory
../../../../lib/packagekit-qt/src/polkitthread.cpp: In member function ‘virtual void PackageKit::PolkitThread::run()’:
../../../../lib/packagekit-qt/src/polkitthread.cpp:29: error: ‘DBusError’ was not declared in this scope
../../../../lib/packagekit-qt/src/polkitthread.cpp:29: error: expected `;' before ‘e’
../../../../lib/packagekit-qt/src/polkitthread.cpp:30: error: ‘e’ was not declared in this scope
../../../../lib/packagekit-qt/src/polkitthread.cpp:30: error: ‘dbus_error_init’ was not declared in this scope
../../../../lib/packagekit-qt/src/polkitthread.cpp:32: error: ‘polkit_check_auth’ was not declared in this scope
../../../../lib/packagekit-qt/src/polkitthread.cpp:40: error: ‘polkit_auth_obtain’ was not declared in this scope

I'm going to revert this patch. We can work on the threading problems in
master, and then backport when it's stable.

Richard.





More information about the PackageKit mailing list