[packagekit] crash because of missing store values
Richard Hughes
hughsient at gmail.com
Fri Oct 10 02:07:23 PDT 2008
On Thu, 2008-10-09 at 15:51 -0600, Scott Reeves wrote:
> pk_transaction_finished_cb was making calls such that threaded
> backends would crash referencing NULL because of missing PkStore
> values. I just pushed a fix to set the values in pk-refresh when it
> makes direct calls to the backend.
Looks good, thanks. I forgot all about this.
> I'm a little concerned about this though because this makes 2 places
> that need to be changed if those method signatures ever change.
Right. I don't see those ever changing right now, but maybe I need to
exercise that code path in make check.
If you run your backend with sudo ./run-pk.sh zypp and then do "make
check" in libpackagekit -- do all the tests pass?
Richard
More information about the PackageKit
mailing list