[packagekit] pylint madness
Tim Lauridsen
tim.lauridsen at googlemail.com
Mon Sep 29 00:36:17 PDT 2008
Richard Hughes wrote:
> On Sun, 2008-09-28 at 08:55 +0200, Tim Lauridsen wrote:
>> stuff like this really real make the code look bad and harder to
>> reader. private worker methods should not be moved out the class they
>> are used in.
>
> Sure, but the functions I've moved out of the class, look like they
> could be made more generic and moved up to the backend.py class. All the
> time they are hidden in the class nobody notices the duplication.
>
> Richard.
>
It is fine to move methods up in the backend class, but keep them in the
class. then is possible to overload the methods and add extra
functionality and so on.
Tim
More information about the PackageKit
mailing list