[packagekit] Is it correct logic to use cache_okay in gpk_check_update_auto_refresh_cache_cb?

Richard Hughes hughsient at gmail.com
Sat Apr 25 14:58:54 PDT 2009


On Sun, 2009-04-26 at 00:21 +0800, Zhu, Peter J wrote:
> In gpk_check_update_auto_refresh_cache_cb of gpk-check-update.c in
> gnome-packagekit-0.4.5, it would return immediately if cache_okay is
> TRUE. But it would set cache_okay to be TRUE once
> gpk_client_refresh_cache() returns successfully. It seems that it
> would update cache only once with the implementation. Do I missing
> something? 

No, you spotted a but that I fixed a few weeks ago. I've removed all the
sync GpkClient stuff and replaced it with async PkClient code. The new
code is much easier to understand IMO.

Richard.





More information about the PackageKit mailing list