[packagekit] [PackageKit-commit] packagekit: Branch 'master' - 9 commits

Richard Hughes hughsient at gmail.com
Fri Feb 13 01:08:41 PST 2009


On Fri, 2009-02-13 at 01:07 -0800, Richard Hughes wrote:
> commit 61c9a8004ae870878b80c1eae901249c63b212bc
> Author: zodman <zodman at cosmogirl.(none)>
> Date:   Thu Feb 12 00:52:32 2009 -0600
> diff --git a/configure.ac b/configure.ac
> index 2b55bd7..e2ef687 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -75,11 +75,11 @@ if test "$GCC" = "yes"; then
>         WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wformat-security"
>         WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wmissing-include-dirs"
>         WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP
> -Wmissing-format-attribute"
> -       WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wclobbered"
> -       WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wempty-body"
> -       WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wignored-qualifiers"
> +       #WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wclobbered"
> +       #WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wempty-body"
> +       #WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wignored-qualifiers"
>         WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wsign-compare"
> -       WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wtype-limits"
> +       #WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wtype-limits"
>         WARNINGFLAGS_CPP="$WARNINGFLAGS_CPP -Wuninitialized"
>  
>         # work only in C
> @@ -89,8 +89,8 @@ if test "$GCC" = "yes"; then
>         WARNINGFLAGS_C="$WARNINGFLAGS_C -Wshadow"
>         WARNINGFLAGS_C="$WARNINGFLAGS_C -Wno-strict-aliasing"
>         WARNINGFLAGS_C="$WARNINGFLAGS_C -Winline"
> -       WARNINGFLAGS_C="$WARNINGFLAGS_C -Wmissing-parameter-type"
> -       WARNINGFLAGS_C="$WARNINGFLAGS_C -Woverride-init"
> +       #WARNINGFLAGS_C="$WARNINGFLAGS_C -Wmissing-parameter-type"
> +       #WARNINGFLAGS_C="$WARNINGFLAGS_C -Woverride-init"
>  else
>         WARNINGFLAGS_C=""
>         WARNINGFLAGS_CPP=""

How come you did this? If your code triggers those warnings then we need
to fix up the code, not turn off the warnings.

Richard.





More information about the PackageKit mailing list