[packagekit] API change/clarification: RequireRestart

[James Westby]

On Thu, 2009-01-15 at 14:52 +0000, Richard Hughes wrote:
> At the moment the API type for the RequireRestart signal is "ss", i.e.
> two strings. The first string is the enumerated type, but the second is
> specified as "Optional details about the restart".
> 
> None of the front-end tools use this optional field, and there's only
> one place in the post-trans hook in the daemon that sets it's to
> anything other than NULL. Basically it's unused.
> 
> I propose we change the second parameter to be a PkPackageObj or a
> PkPackageId so that we can display as a tooltip what package caused the
> restart required signal. This allows users to either defer the decision,
> or do the action based on real information. At the moment we don't tell
> the user what package caused the signal to be emitted. Changing the use
> won't change the signal type, and so won't break the bindings.
> 
> The obvious advantages of a PkPackageObj is that it gives us what the
> package was doing (e.g. INSTALLING) and also a localised summary to
> display in a tooltip. I don't really want to resolve a load of
> package_id's just to get a tooltip that people probably won't read.
> 
> How does this sound?

Should it be an array? Multiple updates can trigger reboot notifications
in one run, and if you have to pick a single one and it is something the
user doesn't care about then they may miss an important restart.

Thanks,

James