[packagekit] search-file pattern search

[Mounir Lamouri]

On Tue, Jun 23, 2009 at 10:57 PM, Richard Hughes<hughsient at gmail.com> wrote:
> On Tue, Jun 23, 2009 at 7:34 PM, Mounir Lamouri<mounir.lamouri at gmail.com> wrote:
>> http://dev.gentoo.org/~volkmar/packagekit-searchfile-error.patch
>
> I think the check belongs in pk_transaction_search_file(), rather than
> pk_transaction_search_check(), as it's only specific to the SearchFile
> method. I might want to SearchDetails for "editors/gedit" and that
> would be perfectly valid.
>
> I would also add a comment explaining what the check is doing, maybe
> something like /* when not an absolute path, disallow slashes in
> search */
>
> With those changes, please commit. Thanks.

Commited