[packagekit] gpk strings

[Richard Hughes]

On Thu, May 14, 2009 at 12:05 AM, Daniel Nicoletti
<dantti85-pk at yahoo.com.br> wrote:
>
> while implementing require restart i notice the following string in
> the present tense:
>
> case PK_RESTART_ENUM_SESSION:
>        text = _("You will need to log out and log back in");
>
> which imo should be
>        text = _("You need to log out and log back in");

Fixed in 083850aec88b9b952a773b6d15866410194e113a, thanks.

> Apart from that i couldn't figure out what restart-schedule is.

Well, it was envisioned as a way for PackageKit to tell clients that
the daemon had been upgraded, and that they should reload themselves,
but it appears in the current code it doesn't do a very good job of
that. There are also no unit tests, so $DEITY only knows if it works
correctly. In fact, looking at the code, it would appear that it's not
doing the right thing at all.

....some code gets written...

commit 76903972eefba8c8df28c93522f7201d88b205d5
Author: Richard Hughes <richard at hughsie.com>
Date:   Thu May 14 10:36:28 2009 +0100

    Add some self tests to PkEngine to ensure that the signals are
being sent correctly

:100644 100644 3bb4963... 5ac329d... M  src/pk-engine.c

commit 95bae5d929c07d6350028a63fc532d9fc1f16d68
Author: Richard Hughes <richard at hughsie.com>
Date:   Thu May 14 10:34:31 2009 +0100

    Fix the logic of ::RestartSchedule and don't make changing the
config file prompt the session to reload

:100644 100644 4c42e71... 3bb4963... M  src/pk-engine.c

commit 53e18773b5a41213d1a7dead6d8e9303000109fb
Author: Richard Hughes <richard at hughsie.com>
Date:   Thu May 14 10:29:51 2009 +0100

    Don't proxy RestartSchedule to PkNotify, only the daemon uses it

:100644 100644 d2a8f37... 4c42e71... M  src/pk-engine.c
:100644 100644 774baa7... 2ff39be... M  src/pk-notify.c
:100644 100644 d941690... 52661cd... M  src/pk-notify.h

commit 77b855c1a2ffd1bc4406c0e0cff6c757a496a795
Author: Richard Hughes <richard at hughsie.com>
Date:   Thu May 14 10:25:13 2009 +0100

    When we do SuggestDaemonQuit with no transactions, exit the daemon
using the mainloop rather than just doing exit()

:100644 100644 e5190a7... d2a8f37... M  src/pk-engine.c
:100644 100644 d5853f9... f022aa2... M  src/pk-main.c

commit 310a9afa3f4676027e009ab79139f206e76eb595
Author: Richard Hughes <richard at hughsie.com>
Date:   Thu May 14 10:20:35 2009 +0100

    Clarify the gtk-doc markup for PkControl::restart-schedule

Could you give this a try please? Thanks.

Richard.