[packagekit] [PATCH 4/4] Get detail info for dependency packages

[Richard Hughes]

On 26 September 2010 04:04, Zhang Qiang <qiang.z.zhang at intel.com> wrote:
> +                       package_ids = pk_package_ids_from_string (package_id);
> +                       /* get the details of dependency packages */
> +                       pk_client_get_update_detail_async (PK_CLIENT(priv->task), package_ids, priv->cancellable,
> +                                                  (PkProgressCallback) gpk_update_viewer_progress_cb, update_viewer,
> +                                                  (GAsyncReadyCallback) gpk_update_viewer_get_update_detail_cb, update_viewer);
> +                       /* get the size of dependency packages */
> +                       pk_client_get_details_async (PK_CLIENT(priv->task), package_ids, priv->cancellable,
> +                                                    (PkProgressCallback) gpk_update_viewer_progress_cb, update_viewer,
> +                                                    (GAsyncReadyCallback) gpk_update_viewer_get_details_cb, update_viewer);

Doesn't this need to be wrapped in "if (role ==
PK_ROLE_ENUM_SIMULATE_UPDATE_PACKAGES) {"?

Otherwise you're going to get the main details and update-info twice, no?

> +                       g_strfreev(package_ids);

g_strfreev<space>(package_ids);

Please. Thanks.

Richard.