[packagekit] commit a6a527f8 broke packagekit

Richard Hughes hughsient at gmail.com
Sat Jun 18 00:54:32 PDT 2011


On 18 June 2011 08:17, Jesse Zhang <zh.jesse at gmail.com> wrote:
> PackageKit is broken with this commit,

Eeek.

>    commit a6a527f8e117d3b8758a30975e87931b8f75d9d5
>    Author: Richard Hughes <richard at hughsie.com>
>    Date:   Thu Jun 16 11:46:47 2011 +0100
>
>        glib: Ensure packages emitted from the progress handler have the package_id assigned correctly
>
> 'pkcon search name' won't return any results.
>
> It works well with the commit reverted. Or does our backend miss any fix?

If I do:

#0  pk_client_package_cb (proxy=0x61df40 [DBusGProxy],
info_text=0x61d7b0 "available", package_id=0x62e210 "",
summary=0x62c9e0 "", state=0x62a030) at pk-client.c:956

You see how the package_id is now "" -- so a clue:

Now, I look at the daemon:

(lt-packagekitd:16202): GLib-GObject-WARNING **: g_object_set_valist:
property `package-id' of object class `PkPackage' is not writable

Right, this is because I made the package-id property of the PkPackage
just readable, and so any g_object_set of the "pakage-id" would fail.
I've fixed this in commit c35a405946beacaaebacdb48eb7b4bd9c0ffe7ca

Thanks for reporting the bug so quick!

Richard.



More information about the PackageKit mailing list