[packagekit] [PATCH] Allow the Plasma version to be specified for PK_PROVIDES_ENUM_PLASMA_SERVICE.

Kevin Kofler kevin.kofler at chello.at
Mon Nov 21 06:54:29 PST 2011


Richard Hughes wrote:
> Yes, the patch looks sane to me, thanks. It's a shame the existing
> provides were not namespaced to plasma4() like the other provide
> strings, but I guess that's the wonderful benefit of hindsight.

The Provides at RPM level have always been namespaced to plasma4(), but 
unfortunately not the strings we passed to the InstallResources API.

But almost all the other existing resource types have the same issue, e.g. 
GStreamer hardcodes the gstreamer0.10 namespace! Python is the only type of 
resource where 2 versioned namespaces are now handled, but the yum and zif 
backends don't support that at all. That's also why I tried to get away with 
doing the same as the other resource types and just hardcoding the 
namespace, but then came KDE Frameworks 5…

> Yup, I think it makes a lot of sense to tie the plasma version to the
> KDE version too.

Right. So I'll stick with the plasma4, and now also plasma5, naming.

I'm going to push the patch as posted to master. Not sure whether it makes 
sense to backport it to 0.6.x. (By the time KDE Frameworks 5 will be 
released, everyone will probably be on 0.7.x anyway.)

        Kevin Kofler




More information about the PackageKit mailing list