[packagekit] [PATCH] Allow plugins to override PolicyKit action IDs

[Matthias Klumpp]

2013/7/17 Richard Hughes <hughsient at gmail.com>:
> On 17 July 2013 12:48, Colin Watson <cjwatson at ubuntu.com> wrote:
>> My current implementation looks like this, FWIW:
>
> Looks about right to me.
>
>> On 0.7, this also requires backporting part of
>> e37591aee89839b44119669b4faa2164511e051a from master, to call
>> pk_transaction_set_full_paths before pk_transaction_obtain_authorization
>> in pk_transaction_install_files; and of course it will require extra
>> code to handle the InstallPackages case when I get that far.  But the
>> general idea is simple enough.
>
> e37591aee89839b44119669b4faa2164511e051a is quite invasive and breaks
> API, it can't be backported to the *stable* 0.7.x
It will also not work on 0.7.x and or at least cause many funny side
effects, because it assumes that previous work on backend-jobs is
present. (and it has never been tested with 0.7)

>> Is there anything else I need to address before this could go into
>> master?
>
> I think it's fine to push your patch to master.
As long as plugins use this carefully, I don't see a problem either :-)

> I also think it might
> be a good idea to update to 0.8.x in Ubuntu as otherwise it's going to
> be very hard to backport all the functionality you need.
I am trying that for ages now ^^ - The fastes way would be if Ubuntu
would switch to PackageKit, and use Aptd only where it makes sense (=
for the Software Center) - then you'd have 0.8.x immediately.
Also, your PK patch obviously doesn't work with Aptd.
There is work going on to get 0.8.x into Ubuntu, but this is blocked
until Aptd supprts the 0.8.x API changes (which were quite invasive,
but necessary).
Cheers,
    Matthias

-- 
Debian Developer | Freedesktop-Developer
KDE-Developer    | GNOME-Contributor
I welcome VSRE emails. See http://vsre.info/