[packagekit] [PATCH] Allow plugins to override PolicyKit action IDs

Colin Watson cjwatson at ubuntu.com
Thu Jul 18 01:43:04 PDT 2013


On Wed, Jul 17, 2013 at 01:24:14PM +0100, Richard Hughes wrote:
> On 17 July 2013 12:48, Colin Watson <cjwatson at ubuntu.com> wrote:
> > On 0.7, this also requires backporting part of
> > e37591aee89839b44119669b4faa2164511e051a from master, to call
> > pk_transaction_set_full_paths before pk_transaction_obtain_authorization
> > in pk_transaction_install_files; and of course it will require extra
> > code to handle the InstallPackages case when I get that far.  But the
> > general idea is simple enough.
> 
> e37591aee89839b44119669b4faa2164511e051a is quite invasive and breaks
> API, it can't be backported to the *stable* 0.7.x

To clarify, I'm certainly not talking about backporting that entire
revision!  That would indeed be madness.  I just mean the tiny bit of
that revision that switches the order of pk_transaction_set_full_paths
and pk_transaction_obtain_authorization in pk_transaction_install_files,
which appears to be quite safe.

> > Is there anything else I need to address before this could go into
> > master?
> 
> I think it's fine to push your patch to master.

Thanks.  I don't think I have permission to do so (although I'm not very
familiar with Gitorious' UI); could you push it for me?

> I also think it might be a good idea to update to 0.8.x in Ubuntu as
> otherwise it's going to be very hard to backport all the functionality
> you need.

I would love to be more current, but that's basically blocked on
Sebastian's aptdaemon work at the moment.  Once that's in place I'd be
happy to support an upgrade.

Cheers,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]


More information about the PackageKit mailing list