[packagekit] [PATCH] Don't crash in pk_transaction_run if ProxyHTTP is set

[Michael Catanzaro]

If ProxyHTTP is set in PackageKit.conf, PackageKit will crash inside
pk_transaction_run [1] [2]. I've been reproducing this by uncommenting
that line and then visiting the Details panel in gnome-control-center.

I believe the problem is that pk_transaction_set_session_state can
improperly return FALSE without setting its GError. I attached a quick
patch; I'm unfamiliar with this code so please review carefully.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=904933
[2] https://bugzilla.redhat.com/show_bug.cgi?id=992890
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PackageKit-ProxyHTTP-Crash.patch
Type: text/x-patch
Size: 761 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20131020/4cd3811d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20131020/4cd3811d/attachment.pgp>