[packagekit] [PATCH] PK-Qt: Absolute vs relative CMAKE_INSTALL_LIBDIR

[Dimstar / Dominique Leuenberger]

Hi all, 

Let me first try to explain the issue seen:
On an installed system (verified openSUSE 13.1 beta as well as Fedora 20
RPMs), the file
/usr/lib64/cmake/packagekit-qt2/packagekit-qt2-config.cmake
contains:

SET(PACKAGEKIT_QT2_LIBRARIES "/usr//usr/lib64/libpackagekit-qt2.so"
CACHE FILEPATH "Libraries for PackageKit-Qt2")

/usr/usr/lib64 is obviously wrong to the trained eye :).

Both (openSUSE and Fedora) build using:
cmake -DCMAKE_INSTALL_LIBDIR=/usr/lib64
CMAKE_INSTALL_PREFIX is not defined and defaults thus to /usr

Changing CMAKE_INSTALL_LIBDIR to be only lib64 would solve the .cmake
content, but then the installation of the library goes to /lib64 (no
more /usr/lib64), which is also not expected.

I tracked it down to various different use cases and notations, which
the attached patch solves in one way (there are certainly other ways as
well).

I discussed this shortly on #PackageKit @ Freenode with Daniel; final
conclusion was that the patch did not look insane (ok, not exactly his
wording.. he formulated it positive).

Best regards,
-- 
Dimstar / Dominique Leuenberger <dimstar at opensuse.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PackageKit-Qt-libdir-references.patch
Type: text/x-patch
Size: 1975 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20130924/5d6176f3/attachment.bin>