[packagekit] hawkey: g_object_unref (file)

Richard Hughes hughsient at gmail.com
Tue Feb 4 09:50:37 CET 2014


On 3 February 2014 15:01, Eugen Wissner <belka.ew at gmail.com> wrote:
> I noticed a possible leak in the pk-backend-hawkey.c. Please see the patch.

Looks good, please push to master.

> And I'm not sure whether also the filename (filename =
> hif_package_get_filename (pkg);) variable should be freed since I don't know
> how hif_package_get_filename exactly works.

_get_filename() returns a const char, so doesn't need to be freed
(it's cleaned up automatically when destroying the package).

Thanks,

Richard


More information about the PackageKit mailing list