[Papyon-bugs] [Bug 37962] papyon does not handle NOT after remote invitation request

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37962

--- Comment #2 from jerico <jerico.dev at gmail.com> 2011-06-12 12:22:13 PDT ---
Louis, please do not yet merge this in. I further investigated the MSNP sharp
implementation. What is actually required after the NOT event is an address
book/membership delta sync and not a check for pending contacts. Otherwise it
is possible that the "pending contacts" event will be fired twice if we also
get an incoming ADL and we may not get the id for the new contact. The fact
that I do not always get an ADL for invitations (aka new REVERSE membership)
must have to do with something else.

I already adapted the sync to handle the NOT command and solve issues I had
with missing contact ids (see recent commits in my fork) but I'd rather test
this a little before we merge it into the mainline. It also doesn't correctly
trigger change events, yet. Maybe you want to comment?

I'm also not sure, yet, whether my address book sync actually captures all
changes. I have a problem with invitations because the contact is in hidden
state after the invitation. I also regularly get a "Hidden Contact with Same
PUID Already Exists" or "Dynamic item already exists" exception when trying to
add contacts that existed, were deleted and then re-invited.

This problem existed in MSNP sharp (see
<http://code.google.com/p/msnp-sharp/issues/detail?id=249>) and has been solved
there. I'll go on porting changes from there until it works for me. I'll just
need quite a bit of time because I'm new to the MSN protocol. Comment is
welcome, of course.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.