[Papyon-bugs] [Bug 35702] New: TLPv1 is broken

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35702

           Summary: TLPv1 is broken
           Product: papyon
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: general
        AssignedTo: papyon-bugs at lists.freedesktop.org
        ReportedBy: c10ud.dev at gmail.com


As tested on irc with lfrb, TLPv1 is currently broken.

Tested with purple and webmessenger, there're some issues which prevent papyon
from downloading correct msnobjects.

lfrb suggests:

        if self.blob_offset + self.chunk_size > self.blob_size:
            #raise TLPParseError(1, "chunk end exceeds blob size", header)
            self.chunk_size = self.blob_size - self.blob_offset
        if self.blob_size >= 0 and self.chunk_size == 0:
            #raise TLPParseError(1, "empty chunk for non-empty blob", header)
            self.chunk_size = self.blob_size

this completes the transfer but the msnobject isn't valid (isn't showed up)

You can test this simply by using emesene2 (which uses papyon-git) and
pidgin/adium. Change your dp in pidgin/adium and you'll see papyon won't get
the updated one.

This could affects filetransfers. Infact with the proposed modification you'll
get an exception when receiving a file from those clients


papyon/msnp2p/transport/TLP.py", line 145, in append_chunk
    assert self.id == chunk.blob_id, "Trying to append a chunk to the wrong
blob"


Setting severity to major since a big number of clients are based on purple et.
al. (like webmessenger)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.