[Papyon] Issue with switchboards

[Riccardo (C10uD)]

Quickly hacked a patch for this and attached. (I can open a bugreport
in bugzilla, but maybe mail is faster?)
I briefly tried with papyon-papyon, papyon-emesene1. If someone else
could take a look, the patch is really tiny, i'm setting the timeouts
only with (sent/received) msgs, i think that's enough.
Didn't try with group conversation, does it change something?

Side note: should we implement keep-alives in papyon with a global killswitch?

greets

2011/3/26 Riccardo (C10uD) <c10ud.dev at gmail.com>:
> Thanks for the prompt answer Youness.
> Now that i think of it i implemented this sort of workaround in
> emesene-1 some time ago, so yes, it's a long-standing issue..
> I also think papyon should take care of it since it's already handling
> all the switchboard stuff. I thought of a single gobject timeout which
> closes the switchboard after 60secs which is killed and recreated by
> every switchboard message sent/received (iirc that's what i did in
> emesene-1). I'll try to hack it quick, if you have a better idea (or
> maybe lfrb has his supersecret branch with the issue already fixed :p)
> just drop a line.
>
> Greets
>
> 2011/3/26 Youness Alaoui <youness.alaoui at collabora.co.uk>:
>> Yes, we saw this issue a few times with aMSN too.. turns out that the
>> switchboard itself is bugged...
>> The issue started a few months ago, maybe a year even.. the switchboards should
>> disconnect you after 5 minutes and send BYE..
>> but sometimes.. some SBs don't... they never tell you you left, they don't tell
>> you the other person left.. so you think the SB is still active.. but they just
>> stop responding...
>> The solution we had to do in aMSN is to do the same thing as WLM : leave the SB
>> after 1 minute of inactivity.. there was no other solution we could find.
>> I suggest that papyon does it, otherwise all clients would need to reimplement
>> this protocol-specific glitch..
>>
>> Youness.
>>
>> On 03/25/2011 06:04 PM, Riccardo (C10uD) wrote:
>>> In emesene2 we're using msnp18, and sometimes i personally experienced
>>> the following issue:
>>> i leave a conversation opened and after some time it's like dead. but
>>> it doesn't tell anything about missing messages or anything. i see
>>> another user found the issue [1].
>>> i was wondering if we should manually handle the conversation.leave()
>>> after a given amount of time, or papyon should tackle that
>>> automagically. or the other party is using a crappy client that
>>> doesn't do X and breaks our switchboards.
>>> How about it? did you ever see such issue? Ideas?
>>>
>>> [1] - https://github.com/emesene/emesene/issues#issue/347
>>> _______________________________________________
>>> papyon mailing list
>>> papyon at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/papyon
>>
>>
>>
>> _______________________________________________
>> papyon mailing list
>> papyon at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/papyon
>>
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Set-switchboard-timeout-to-60-seconds.patch
Type: text/x-patch
Size: 2759 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/papyon/attachments/20110326/ce8fae24/attachment.bin>