[Piglit] [PATCH] arb_color_buffer_float-mrt: Fix handling of buffer0's fixedness.

Marek Olšák maraeo at gmail.com
Fri Apr 15 17:32:43 PDT 2011


Looks good to me.

Marek

On Sat, Apr 16, 2011 at 1:31 AM, Eric Anholt <eric at anholt.net> wrote:

> These two tests were trying to check what buffer 0's type was, not
> whether the pipeline as a whole was "fixed" for the purpose of
> clamping.
> ---
>  tests/spec/arb_color_buffer_float/mrt.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/spec/arb_color_buffer_float/mrt.c
> b/tests/spec/arb_color_buffer_float/mrt.c
> index a13d0fb..f2e12fd 100644
> --- a/tests/spec/arb_color_buffer_float/mrt.c
> +++ b/tests/spec/arb_color_buffer_float/mrt.c
> @@ -97,14 +97,14 @@ test()
>                glDisable(GL_FRAGMENT_PROGRAM_ARB);
>
>                expected = clamped ? clamped_pixels :
> -                          fixed ? clamped_pixels :
> +                          fixed0 ? clamped_pixels :
>                           pixels;
>                expected1 = clamped ? clamped_pixels :
>                            fixed1 ? clamped_pixels :
>                            pixels;
>
>                glReadBuffer(GL_COLOR_ATTACHMENT0);
> -               printf("Probing buffer 0 (%s)\n", fixed ? "fixed point" :
> "floating point");
> +               printf("Probing buffer 0 (%s)\n", fixed0 ? "fixed point" :
> "floating point");
>                cpass = piglit_probe_pixel_rgba(0, 0, expected) && cpass;
>                glReadBuffer(GL_COLOR_ATTACHMENT1);
>                printf("Probing buffer 1 (%s)\n", fixed1 ? "fixed point" :
> "floating point");
> --
> 1.7.4.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20110416/26cd2d45/attachment.html>


More information about the Piglit mailing list