[Piglit] [PATCH] piglit-run.py: Remove SyncFileWriter as it's not necessary with JSON.

Eric Anholt eric at anholt.net
Wed Aug 3 17:08:03 PDT 2011

On Wed,  3 Aug 2011 12:09:53 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Prior to JSON-ification, piglit wrote each test's results in a single
> call, and SyncFileWriter ensured that these were done sequentially.
> Now, the JSON writer internally handles locking and concurrency, so
> SyncFileWriter is unnecessary.  Furthermore, outputting a single test's
> results now takes multiple write calls, so SyncFileWriter wouldn't actually
> guard against concurrency issues anyway.
> This also removes a fsync() call on each write, fixing a major
> performance regression on machines with non-SSDs.  Prior to the JSON
> work, since each test mapped to a single write call, we were doing one
> fsync() per test case.  With JSON, we started doing many more fsyncs.
> But none of them are actually necessary, so just scrap them all.
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=39737
> Cc: Chad Versace <chad at chad-versace.us>
> Cc: Ian Romanick <idr at freedesktop.org>
> Cc: Dave Airlie <airlied at gmail.com>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Apparently the fsync was also the largest cause of the slowness I've had
with my sshfs setup.  Thanks for fixing this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20110803/cec6b71d/attachment.pgp>

More information about the Piglit mailing list