[Piglit] [PATCH] Add tests for gl_ClipDistance and gl_ClipVertex.

Paul Berry stereotype441 at gmail.com
Wed Aug 10 09:16:08 PDT 2011


On 9 August 2011 18:28, Eric Anholt <eric at anholt.net> wrote:
>
> I generally find clipping hard to think about (which is why I'm not
> giving a Reviewed-by:), but I'm quite happy with this series and the
> coverage it provides.  We've needed a bunch of these tests.
>

Thanks, Eric.  I am fairly confident in all the ones that pass on
nVidia, and I think I will shake out any flaws in the others as I'm
doing the Mesa implementation of gl_ClipDistance.  If nobody else
chimes in with a review in the next day or two, I'll go ahead and push
the patches anyway.  It's not like they're going to break anybody's
Piglit runs (unlike some other Piglit patches I've made recently,
heh), and we can always make later corrections if the need arises.


More information about the Piglit mailing list