[Piglit] [PATCH 07/14] glx_ext_import_context: Verify function of glXFreeContextEXT

Ian Romanick idr at freedesktop.org
Thu Dec 8 15:41:54 PST 2011


From: Ian Romanick <ian.d.romanick at intel.com>

This test fails on NVIDIA's closed-source driver for a couple reasons.
First, inspite of what the spec says, they appear to release the
server-side context when glXFreeContextEXT is called.  Second, they do
not generate a GLXBadContext error when a NULL context is freed.

This test fails on AMD's closed-source driver because it hits an
assertion failure in XCB:

xcb_io.c:515: _XReply: Assertion `!dpy->xcb->reply_data' failed.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                    |    1 +
 .../spec/glx_ext_import_context/CMakeLists.gl.txt  |    1 +
 tests/spec/glx_ext_import_context/free-context.c   |  105 ++++++++++++++++++++
 3 files changed, 107 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/glx_ext_import_context/free-context.c

diff --git a/tests/all.tests b/tests/all.tests
index a5591e1..8494384 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -621,6 +621,7 @@ glx['glx-query-drawable-GLXBadDrawable'] = PlainExecTest(['glx-query-drawable',
 
 import_context = Group();
 glx['GLX_EXT_import_context'] = import_context
+import_context['free context'] = PlainExecTest(['glx-free-context'])
 import_context['get context ID'] = PlainExecTest(['glx-get-context-id'])
 
 texturing = Group()
diff --git a/tests/spec/glx_ext_import_context/CMakeLists.gl.txt b/tests/spec/glx_ext_import_context/CMakeLists.gl.txt
index f2ad262..cb99c18 100644
--- a/tests/spec/glx_ext_import_context/CMakeLists.gl.txt
+++ b/tests/spec/glx_ext_import_context/CMakeLists.gl.txt
@@ -15,6 +15,7 @@ link_libraries (
 )
 
 IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
+	add_executable (glx-free-context free-context.c common.c)
 	add_executable (glx-get-context-id get-context-id.c common.c)
 ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
 
diff --git a/tests/spec/glx_ext_import_context/free-context.c b/tests/spec/glx_ext_import_context/free-context.c
new file mode 100644
index 0000000..5bad0ff
--- /dev/null
+++ b/tests/spec/glx_ext_import_context/free-context.c
@@ -0,0 +1,105 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+#include "piglit-util.h"
+#include "piglit-glx-util.h"
+#include "common.h"
+
+static bool try_free_context(GLXContext ctx, enum context_mode mode,
+			     const char *extra)
+{
+	bool pass;
+	const GLXContextID id =
+		(mode != invalid) ? glXGetContextIDEXT(ctx) : None;
+
+	/* Free the context.
+	 */
+	glXFreeContextEXT(dpy, ctx);
+	XSync(dpy, 0);
+
+	pass = validate_glx_error_code(Success, -1);
+	if (!pass)
+		fprintf(stderr, "Context is %s in free\n\n", extra);
+
+	/* The GLX_EXT_import_context spec says:
+	 *
+	 *     "glXFreeContext does not free the server-side context
+	 *     information or the XID associated with the server-side
+	 *     context."
+	 *
+	 * Attempt to verify that the context still exists on the server by
+	 * trying to import it again.
+	 */
+	if (mode != invalid && pass) {
+		assert(id != None);
+
+		pass = try_import_context(id, mode);
+		if (!pass)
+			fprintf(stderr, "Context is %s in re-import\n\n",
+				extra);
+	}
+
+
+	return pass;
+}
+
+int main(int argc, char **argv)
+{
+	bool pass = true;
+	GLXContext ctx;
+
+	GLX_EXT_import_context_setup();
+	get_context_IDs();
+
+	ctx = glXImportContextEXT(dpy, indirectID);
+	if (ctx == NULL) {
+		fprintf(stderr, "Could not import indirect context.\n");
+		piglit_report_result(PIGLIT_FAIL);
+	}
+
+	pass = try_free_context(ctx, indirect_rendering,
+				"an imported context")
+		&& pass;
+	ctx = NULL;
+
+	if (directCtx != NULL) {
+		pass = try_free_context(directCtx, direct_rendering,
+					"a non-imported direct-rendering "
+					"context")
+			&& pass;
+		directCtx = NULL;
+	}
+
+	pass = try_free_context(indirectCtx, indirect_rendering,
+				"a non-imported indirect-rendering context")
+		&& pass;
+	indirectCtx = NULL;
+
+	pass = try_free_context(NULL, invalid,
+				"a NULL pointer / invalid context")
+		&& pass;
+
+	GLX_EXT_import_context_teardown();
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+	return 0;
+}
-- 
1.7.6.4



More information about the Piglit mailing list