[Piglit] [PATCH] glsl-1.10: Verify that C99 digraphs aren't treated specially in GLSL
Ian Romanick
idr at freedesktop.org
Thu Dec 8 17:38:45 PST 2011
On 12/08/2011 01:55 PM, Kenneth Graunke wrote:
> On 12/07/2011 03:32 PM, Ian Romanick wrote:
>> From: Ian Romanick<ian.d.romanick at intel.com>
>>
>> Right now the digraph-close-bracket tests cause a segfault (or an
>> assertion failure) in Mesa's GLSL compiler.
>>
>> Signed-off-by: Ian Romanick<ian.d.romanick at intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43564
>> Cc: Yi Sun<yi.sun at intel.com>
>
> Ian,
>
> I was never clear whether digraphs should or shouldn't be interpreted.
> I think the only argument in favor is the "as is standard for C++
> preprocessors" text, and I thought digraphs were done translated by the
> C++ preprocessor. Which is pretty weak. But the symbols making up the
> digraphs are in the character set, so I'm uncertain.
>
> Can you back this up somehow? Spec language, test cases from other
> suites, or other driver behavior would suffice. I definitely prefer not
> having to interpret them.
I seem to recall the spec saying the trigraphs are not interpreted
specially, and I though digraphs were only in C99 (not C++). I'll dig
some more.
More information about the Piglit
mailing list