[Piglit] [PATCH] fbo-blit-d24s8: don't try to blit between different Z/stencil depths

Eric Anholt eric at anholt.net
Wed Dec 14 09:59:47 PST 2011

On Tue, 13 Dec 2011 17:58:34 -0700, Brian Paul <brian.e.paul at gmail.com> wrote:
> From: Brian Paul <brianp at vmware.com>
> The docs for glBlitFramebuffer say GL_INVALID_OPERATION is generated
> if the source/dest depth/stencil buffer formats do no match.  The spec
> is a bit vague on what's meant by formats (do just the component depths
> need to match, or must the hw formats match?) but clearly if the depths
> don't match, the formats can't match.
> This fixes a bogus error that's generated when testing swrast which
> usually uses a 16-bit depth buffer for the window and a 24-bit Z
> renderbuffer for the FBO.

Wow, they made it so you don't have to blit different-format
depth/stencil (easy), but they made you do CopyPixels-style format
conversions on color (hard)?  Way to go, spec authors.

It looks like this would be a lot easier and a more accurate result if
you just report PIGLIT_SKIP if the depths don't match.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111214/d2d8b397/attachment.pgp>

More information about the Piglit mailing list