[Piglit] [PATCH 09/12] glx_arb_create_context: Verify rejection of forward-compatible flag w/pre-3.0
Ian Romanick
idr at freedesktop.org
Wed Dec 14 10:47:28 PST 2011
From: Ian Romanick <ian.d.romanick at intel.com>
NVIDIA's closed-source driver fails this test because it generates the
wrong X error (BadAlloc instead of BadMatch). It correctly does not
create the context.
AMD's closed-source driver fails this test because it does not
generate any X error. It correctly does not create the context.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
tests/all.tests | 1 +
.../spec/glx_arb_create_context/CMakeLists.gl.txt | 1 +
.../invalid-flag-forward-compatible.c | 143 ++++++++++++++++++++
3 files changed, 145 insertions(+), 0 deletions(-)
create mode 100644 tests/spec/glx_arb_create_context/invalid-flag-forward-compatible.c
diff --git a/tests/all.tests b/tests/all.tests
index 7af5a1f..9172798 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -629,6 +629,7 @@ create_context['default major version'] = PlainExecTest(['glx-create-context-def
create_context['default minor version'] = PlainExecTest(['glx-create-context-default-minor-version'])
create_context['invalid attribute'] = PlainExecTest(['glx-create-context-invalid-attribute'])
create_context['invalid flag'] = PlainExecTest(['glx-create-context-invalid-flag'])
+create_context['forward-compatible flag with pre-3.0'] = PlainExecTest(['glx-create-context-invalid-flag-forward-compatible'])
create_context['invalid OpenGL version'] = PlainExecTest(['glx-create-context-invalid-gl-version'])
create_context['empty attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-empty'])
create_context['NULL attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-null'])
diff --git a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
index a8c3f61..a31e606 100644
--- a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
+++ b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
@@ -19,6 +19,7 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
add_executable (glx-create-context-default-minor-version default-minor-version.c common.c)
add_executable (glx-create-context-invalid-attribute invalid-attribute.c common.c)
add_executable (glx-create-context-invalid-flag invalid-flag.c common.c)
+ add_executable (glx-create-context-invalid-flag-forward-compatible invalid-flag-forward-compatible.c common.c)
add_executable (glx-create-context-invalid-gl-version invalid-gl-version.c common.c)
add_executable (glx-create-context-valid-attribute-empty valid-attribute-empty.c common.c)
add_executable (glx-create-context-valid-attribute-null valid-attribute-null.c common.c)
diff --git a/tests/spec/glx_arb_create_context/invalid-flag-forward-compatible.c b/tests/spec/glx_arb_create_context/invalid-flag-forward-compatible.c
new file mode 100644
index 0000000..8017ac9
--- /dev/null
+++ b/tests/spec/glx_arb_create_context/invalid-flag-forward-compatible.c
@@ -0,0 +1,143 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util.h"
+#include "piglit-glx-util.h"
+#include "common.h"
+
+static bool check_version(int major, int minor)
+{
+ const int attribs[] = {
+ GLX_CONTEXT_MAJOR_VERSION_ARB, major,
+ GLX_CONTEXT_MINOR_VERSION_ARB, minor,
+ None
+ };
+ GLXContext ctx;
+
+ ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, attribs);
+ if (ctx != NULL) {
+ glXDestroyContext(dpy, ctx);
+ return true;
+ }
+
+ return false;
+}
+
+static bool try_version(int major, int minor)
+{
+ const int attribs[] = {
+ GLX_CONTEXT_MAJOR_VERSION_ARB, major,
+ GLX_CONTEXT_MINOR_VERSION_ARB, minor,
+ GLX_CONTEXT_FLAGS_ARB, GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB,
+ None
+ };
+ GLXContext ctx;
+ bool pass = true;
+
+ ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, attribs);
+ XSync(dpy, 0);
+
+ if (ctx != NULL) {
+ fprintf(stderr,
+ "Created OpenGL context %d.%d with forward-compatible "
+ "flag, but this should have failed.\n",
+ major, minor);
+ glXDestroyContext(dpy, ctx);
+ pass = false;
+ }
+
+ /* The GLX_ARB_create_context spec says:
+ *
+ * "If attributes GLX_CONTEXT_MAJOR_VERSION_ARB and
+ * GLX_CONTEXT_MINOR_VERSION_ARB, when considered together with
+ * attributes GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB and
+ * GLX_RENDER_TYPE, specify an OpenGL version and feature set that
+ * are not defined, BadMatch is generated."
+ */
+ if (!validate_glx_error_code(BadMatch, -1)) {
+ if (ctx == NULL)
+ fprintf(stderr, "Version = %d.%d\n", major, minor);
+
+ pass = false;
+ }
+
+ return pass;
+}
+
+int main(int argc, char **argv)
+{
+ static const struct {
+ int major;
+ int minor;
+ bool must_pass;
+ } all_gl_versions[] = {
+ { 1, 0, true },
+ { 1, 1, true },
+ { 1, 2, true },
+ { 1, 3, false },
+ { 1, 4, false },
+ { 1, 5, false },
+ { 2, 0, false },
+ { 2, 1, false }
+ };
+ bool pass = true;
+ unsigned i;
+
+ GLX_ARB_create_context_setup();
+
+ /* The GLX_ARB_create_context spec says:
+ *
+ * "The defined versions of OpenGL at the time of writing are
+ * OpenGL 1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 2.0, 2.1, 3.0, 3.1, and
+ * 3.2. Feature deprecation was introduced with OpenGL 3.0, so
+ * forward-compatible contexts may only be requested for OpenGL
+ * 3.0 and above. Thus, examples of invalid combinations of
+ * attributes include:
+ *
+ * - Major version < 1 or > 3
+ * - Major version == 1 and minor version < 0 or > 5
+ * - Major version == 2 and minor version < 0 or > 1
+ * - Major version == 3 and minor version > 2
+ * - Forward-compatible flag set and major version < 3
+ * - Color index rendering and major version >= 3"
+ */
+ for (i = 0; i < ARRAY_SIZE(all_gl_versions); i++) {
+ if (!all_gl_versions[i].must_pass
+ && !check_version(all_gl_versions[i].major,
+ all_gl_versions[i].minor)) {
+ printf("OpenGL version %d.%d not supported by this "
+ "implementation. Skipping forward-"
+ "compatibility flag check.\n",
+ all_gl_versions[i].major,
+ all_gl_versions[i].minor);
+ continue;
+ }
+
+ pass = try_version(all_gl_versions[i].major,
+ all_gl_versions[i].minor)
+ && pass;
+ }
+
+ GLX_ARB_create_context_teardown();
+
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+ return 0;
+}
--
1.7.6.4
More information about the Piglit
mailing list