[Piglit] [PATCH 10/12] glx_arb_create_context: Verify that the forward-compatible flag can be accepted

Ian Romanick idr at freedesktop.org
Wed Dec 14 10:47:29 PST 2011


From: Ian Romanick <ian.d.romanick at intel.com>

The flag can be used with OpenGL 3.0+, but the implementation can
still reject it.  If it does, it must produce a particular GLX error.

Both AMD's and NVIDIA's closed-source drivers pass this test.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                    |    1 +
 .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
 .../valid-flag-forward-compatible.c                |   70 ++++++++++++++++++++
 3 files changed, 72 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/glx_arb_create_context/valid-flag-forward-compatible.c

diff --git a/tests/all.tests b/tests/all.tests
index 9172798..aaa8172 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -633,6 +633,7 @@ create_context['forward-compatible flag with pre-3.0'] = PlainExecTest(['glx-cre
 create_context['invalid OpenGL version'] = PlainExecTest(['glx-create-context-invalid-gl-version'])
 create_context['empty attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-empty'])
 create_context['NULL attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-null'])
+create_context['forward-compatible flag with 3.0'] = PlainExecTest(['glx-create-context-valid-flag-forward-compatible'])
 
 texturing = Group()
 add_concurrent_test(texturing, '1-1-linear-texture')
diff --git a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
index a31e606..8591f5e 100644
--- a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
+++ b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
@@ -23,6 +23,7 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
 	add_executable (glx-create-context-invalid-gl-version invalid-gl-version.c common.c)
 	add_executable (glx-create-context-valid-attribute-empty valid-attribute-empty.c common.c)
 	add_executable (glx-create-context-valid-attribute-null valid-attribute-null.c common.c)
+	add_executable (glx-create-context-valid-flag-forward-compatible valid-flag-forward-compatible.c common.c)
 ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
 
 # vim: ft=cmake:
diff --git a/tests/spec/glx_arb_create_context/valid-flag-forward-compatible.c b/tests/spec/glx_arb_create_context/valid-flag-forward-compatible.c
new file mode 100644
index 0000000..17f408d
--- /dev/null
+++ b/tests/spec/glx_arb_create_context/valid-flag-forward-compatible.c
@@ -0,0 +1,70 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util.h"
+#include "piglit-glx-util.h"
+#include "common.h"
+
+static bool try_flag(int flag)
+{
+	const int attribs[] = {
+		GLX_CONTEXT_MAJOR_VERSION_ARB, 3,
+		GLX_CONTEXT_FLAGS_ARB, flag,
+		None
+	};
+	GLXContext ctx;
+
+	ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, attribs);
+	XSync(dpy, 0);
+
+	if (ctx != NULL) {
+		glXDestroyContext(dpy, ctx);
+	} else {
+		/* The GLX_ARB_create_context spec says:
+		 *
+		 *     "* If <config> does not support compatible OpenGL
+		 *        contexts providing the requested API major and minor
+		 *        version, forward-compatible flag, and debug context
+		 *        flag, GLXBadFBConfig is generated."
+		 */
+		if (!validate_glx_error_code(0, GLXBadFBConfig)) {
+			fprintf(stderr, "flag = 0x%08x\n", flag);
+			return false;
+		}
+	}
+
+	return true;
+}
+
+int main(int argc, char **argv)
+{
+	bool pass = true;
+
+	GLX_ARB_create_context_setup();
+
+	pass = try_flag(0) && pass;
+	pass = try_flag(GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB) && pass;
+
+	GLX_ARB_create_context_teardown();
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+	return 0;
+}
-- 
1.7.6.4



More information about the Piglit mailing list