[Piglit] [PATCH 11/12] glx_arb_create_context: Verify that invalid render types are rejected

[Ian Romanick]

From: Ian Romanick <ian.d.romanick at intel.com>

NVIDIA's closed-source driver passes this test.

AMD's closed-source driver fails this test because it creates contexts
with invalid render types.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                    |    1 +
 .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
 .../glx_arb_create_context/invalid-render-type.c   |   98 ++++++++++++++++++++
 3 files changed, 100 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/glx_arb_create_context/invalid-render-type.c

diff --git a/tests/all.tests b/tests/all.tests
index aaa8172..99b2d24 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -631,6 +631,7 @@ create_context['invalid attribute'] = PlainExecTest(['glx-create-context-invalid
 create_context['invalid flag'] = PlainExecTest(['glx-create-context-invalid-flag'])
 create_context['forward-compatible flag with pre-3.0'] = PlainExecTest(['glx-create-context-invalid-flag-forward-compatible'])
 create_context['invalid OpenGL version'] = PlainExecTest(['glx-create-context-invalid-gl-version'])
+create_context['invalid render type'] = PlainExecTest(['glx-create-context-invalid-render-type'])
 create_context['empty attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-empty'])
 create_context['NULL attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-null'])
 create_context['forward-compatible flag with 3.0'] = PlainExecTest(['glx-create-context-valid-flag-forward-compatible'])
diff --git a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
index 8591f5e..429d742 100644
--- a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
+++ b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
@@ -21,6 +21,7 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
 	add_executable (glx-create-context-invalid-flag invalid-flag.c common.c)
 	add_executable (glx-create-context-invalid-flag-forward-compatible invalid-flag-forward-compatible.c common.c)
 	add_executable (glx-create-context-invalid-gl-version invalid-gl-version.c common.c)
+	add_executable (glx-create-context-invalid-render-type invalid-render-type.c common.c)
 	add_executable (glx-create-context-valid-attribute-empty valid-attribute-empty.c common.c)
 	add_executable (glx-create-context-valid-attribute-null valid-attribute-null.c common.c)
 	add_executable (glx-create-context-valid-flag-forward-compatible valid-flag-forward-compatible.c common.c)
diff --git a/tests/spec/glx_arb_create_context/invalid-render-type.c b/tests/spec/glx_arb_create_context/invalid-render-type.c
new file mode 100644
index 0000000..a6ffa1e
--- /dev/null
+++ b/tests/spec/glx_arb_create_context/invalid-render-type.c
@@ -0,0 +1,98 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util.h"
+#include "piglit-glx-util.h"
+#include "common.h"
+
+static bool try_render_type(int type)
+{
+	const int attribs[] = {
+		GLX_RENDER_TYPE, type,
+		None
+	};
+	GLXContext ctx;
+	bool pass = true;
+
+	ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, attribs);
+	XSync(dpy, 0);
+
+	if (ctx != NULL) {
+		fprintf(stderr,
+			"Created OpenGL context with invalid render-type "
+			"0x%08x, but this should have failed.\n",
+			type);
+		glXDestroyContext(dpy, ctx);
+		pass = false;
+	}
+
+	/* The GLX_ARB_create_context spec says:
+	 *
+	 *     "* If attribute GLX_RENDER_TYPE does not describe a valid
+	 *        rendering type, BadValue is generated."
+	 */
+	if (!validate_glx_error_code(BadValue, -1)) {
+		if (ctx == NULL)
+			fprintf(stderr, "Render type = 0x%08x\n", type);
+
+		pass = false;
+	}
+
+	return pass;
+}
+
+int main(int argc, char **argv)
+{
+	static const int invalid_render_types[] = {
+		GLX_COLOR_INDEX_BIT,
+		GLX_RGBA_BIT,
+		GLX_RGBA_FLOAT_BIT_ARB,
+		GLX_RGBA_UNSIGNED_FLOAT_BIT_EXT,
+		0,
+		-1,
+		~GLX_RGBA_TYPE,
+		~GLX_COLOR_INDEX_TYPE
+	};
+	bool pass = true;
+	unsigned i;
+
+	GLX_ARB_create_context_setup();
+
+	for (i = 0; i < ARRAY_SIZE(invalid_render_types); i++) {
+		pass = try_render_type(invalid_render_types[i])
+			&& pass;
+	}
+
+	if (!piglit_is_glx_extension_supported(dpy, "GLX_ARB_fbconfig_float")) {
+		pass = try_render_type(GLX_RGBA_FLOAT_TYPE_ARB)
+			&& pass;
+	}
+
+	if (!piglit_is_glx_extension_supported(dpy, "GLX_EXT_fbconfig_packed_float")) {
+		pass = try_render_type(GLX_RGBA_UNSIGNED_FLOAT_TYPE_EXT)
+			&& pass;
+	}
+
+	GLX_ARB_create_context_teardown();
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+	return 0;
+}
-- 
1.7.6.4