[Piglit] [PATCH 12/12] glx_arb_create_context: Verify that color-index rendering is rejected with OpenGL 3.0

Ian Romanick idr at freedesktop.org
Wed Dec 14 10:47:31 PST 2011


From: Ian Romanick <ian.d.romanick at intel.com>

Both AMD's and NVIDIA's closed-source drivers fail this test becuase
they create OpenGL 3.0 contexts with color-index render type.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                    |    1 +
 .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
 .../invalid-render-type-color-index.c              |  112 ++++++++++++++++++++
 3 files changed, 114 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/glx_arb_create_context/invalid-render-type-color-index.c

diff --git a/tests/all.tests b/tests/all.tests
index 99b2d24..8f009d0 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -632,6 +632,7 @@ create_context['invalid flag'] = PlainExecTest(['glx-create-context-invalid-flag
 create_context['forward-compatible flag with pre-3.0'] = PlainExecTest(['glx-create-context-invalid-flag-forward-compatible'])
 create_context['invalid OpenGL version'] = PlainExecTest(['glx-create-context-invalid-gl-version'])
 create_context['invalid render type'] = PlainExecTest(['glx-create-context-invalid-render-type'])
+create_context['color-index render type with 3.0'] = PlainExecTest(['glx-create-context-invalid-render-type-color-index'])
 create_context['empty attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-empty'])
 create_context['NULL attribute list'] = PlainExecTest(['glx-create-context-valid-attribute-null'])
 create_context['forward-compatible flag with 3.0'] = PlainExecTest(['glx-create-context-valid-flag-forward-compatible'])
diff --git a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
index 429d742..3b70207 100644
--- a/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
+++ b/tests/spec/glx_arb_create_context/CMakeLists.gl.txt
@@ -22,6 +22,7 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
 	add_executable (glx-create-context-invalid-flag-forward-compatible invalid-flag-forward-compatible.c common.c)
 	add_executable (glx-create-context-invalid-gl-version invalid-gl-version.c common.c)
 	add_executable (glx-create-context-invalid-render-type invalid-render-type.c common.c)
+	add_executable (glx-create-context-invalid-render-type-color-index invalid-render-type-color-index.c common.c)
 	add_executable (glx-create-context-valid-attribute-empty valid-attribute-empty.c common.c)
 	add_executable (glx-create-context-valid-attribute-null valid-attribute-null.c common.c)
 	add_executable (glx-create-context-valid-flag-forward-compatible valid-flag-forward-compatible.c common.c)
diff --git a/tests/spec/glx_arb_create_context/invalid-render-type-color-index.c b/tests/spec/glx_arb_create_context/invalid-render-type-color-index.c
new file mode 100644
index 0000000..50c44a3
--- /dev/null
+++ b/tests/spec/glx_arb_create_context/invalid-render-type-color-index.c
@@ -0,0 +1,112 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util.h"
+#include "piglit-glx-util.h"
+#include "common.h"
+
+static bool check_version(int major, int minor, int *flags)
+{
+	int attribs[] = {
+		GLX_CONTEXT_MAJOR_VERSION_ARB, major,
+		GLX_CONTEXT_MINOR_VERSION_ARB, minor,
+		GLX_CONTEXT_FLAGS_ARB, 0,
+		None
+	};
+	GLXContext ctx;
+
+	ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, attribs);
+	if (ctx != NULL) {
+		glXDestroyContext(dpy, ctx);
+		*flags = attribs[5];
+		return true;
+	}
+
+	attribs[5] = GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB;
+	ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, attribs);
+	if (ctx != NULL) {
+		glXDestroyContext(dpy, ctx);
+		*flags = attribs[5];
+		return true;
+	}
+
+	return false;
+}
+
+static bool try_render_type(int type, int flags)
+{
+	const int attribs[] = {
+		GLX_CONTEXT_MAJOR_VERSION_ARB, 3,
+		GLX_RENDER_TYPE, type,
+		GLX_CONTEXT_FLAGS_ARB, flags,
+		None
+	};
+	GLXContext ctx;
+	bool pass = true;
+
+	ctx = glXCreateContextAttribsARB(dpy, fbconfig, NULL, True, attribs);
+	XSync(dpy, 0);
+
+	if (ctx != NULL) {
+		fprintf(stderr,
+			"Created OpenGL context with invalid render-type "
+			"0x%08x, but this should have failed.\n",
+			type);
+		glXDestroyContext(dpy, ctx);
+		pass = false;
+	}
+
+	/* The GLX_ARB_create_context spec says:
+	 *
+	 *     "OpenGL contexts supporting version 3.0 or later of the API do
+	 *     not support color index rendering, even if a color index
+	 *     <config> is available.
+	 *
+	 *     ...
+	 *
+	 *     If attributes GLX_CONTEXT_MAJOR_VERSION_ARB and
+	 *     GLX_CONTEXT_MINOR_VERSION_ARB, when considered together with
+	 *     attributes GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB and
+	 *     GLX_RENDER_TYPE, specify an OpenGL version and feature set that
+	 *     are not defined, BadMatch is generated."
+	 */
+	return validate_glx_error_code(BadMatch, -1) && pass;
+}
+
+int main(int argc, char **argv)
+{
+	bool pass = true;
+	int flags;
+
+	GLX_ARB_create_context_setup();
+
+	if (!check_version(3, 0, &flags)) {
+		printf("Test requires OpenGL 3.0.\n");
+		piglit_report_result(PIGLIT_SKIP);
+	}
+
+	pass = try_render_type(GLX_COLOR_INDEX_TYPE, flags);
+
+	GLX_ARB_create_context_teardown();
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+	return 0;
+}
-- 
1.7.6.4



More information about the Piglit mailing list