[Piglit] [PATCH 1/4] gl-3.0: Verify linking errors to due invalid glBindFragDataLocation assignments

Chad Versace chad.versace at linux.intel.com
Wed Dec 14 11:14:31 PST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/16/2011 01:50 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> This test fails on AMD's closed-source driver and NVIDIA's
> closed-source driver because they both allow an array to be assigned
> to location GL_MAX_DRAW_BUFFERS-1.  See comments in the test for the
> reasons this should be rejected.  AMD's closed-source driver also
> fails to reject overlapping location assignments for 'a[1]' and 'v'.
> 
> v2: Verify that setting a and v to valid locations after a failing
> link can link successfully.  Suggested by Paul Berry.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  tests/all.tests                                 |    1 +
>  tests/spec/gl-3.0/api/CMakeLists.gl.txt         |    1 +
>  tests/spec/gl-3.0/api/bindfragdata-link-error.c |  190 +++++++++++++++++++++++
>  3 files changed, 192 insertions(+), 0 deletions(-)
>  create mode 100644 tests/spec/gl-3.0/api/bindfragdata-link-error.c

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO6PWVAAoJEAIvNt057x8iehEP/R8B8rBzawOmaa/f9C11rzIW
JbPY9+TgBvjud46gx/5oO4Efb0r9I7qxEMj2QY+CedTUcGsot3KpCCUpftBSswqG
AglPjFGjzKL/11vUJh7teh9DhUpfADAqnpK8eXlOHOthGQvRgwDhI9HnjcXrCfRX
iXOHvkmUj/dsdI+kj0RjM9h9SeAdFJoIhvFz5/kBH4AfDy3kuhykpknJt45Cmhq5
b4SMt+kAuv1fHf2OHOy093/do2+We7OzXjxLi1fJTe9Kn4qWRu3NiUWbZcT4i9qM
Tw5FZk86s0iEDUvbTAG/PVfrGcwZ0G+h1zzFNxb9SWjnbnJEceE9IQjtCgnk82l+
Z+vASc6Y/sc51hAQBj/BOBdHx5q7V8DCcExLy23bWwyJKu1gfRMibAbBLSh+/4r5
E62RJ0Ws0Dpbp1bEOyWZK6S1REST3a1vapvPAtzh/rp7bJKcIdy/LHG2LLtpPpLE
DO7jGiEzdzmR3n4POQlppkkG4TVS4+kEe9M6qW+PA8ymkaRll0e1Uwz6CmCovzJk
DwFGGfMi3yhN5+aNfXKVTjWUNi46cfr+0hgCNMm1ANebwUXuJ3C/PTzjRPIF2Hc2
zFtGhoc1VZIiZrA0ih1gULQWoMrK7XY5nKALmF4MqT1j8SJQMnbdmq+dmvYY1z+W
vtQ0+Mdzfwg2Ar+NKAgS
=erAa
-----END PGP SIGNATURE-----


More information about the Piglit mailing list