[Piglit] [PATCH] Add test case on error check on glGetTexImage with type GL_UNSIGNED_INT_10F_11F_11F_REV should be GL_INVALID_OPERATION. As glGetTexImage in OpenGL 4.2 Reference Pages:

[Zhao, Jian J]

> -----Original Message-----
> From: Brian Paul [mailto:brianp at vmware.com]
> Sent: Wednesday, December 14, 2011 9:44 PM
> To: Zhao, Jian J
> Cc: piglit at lists.freedesktop.org
> Subject: Re: [Piglit] [PATCH] Add test case on error check on glGetTexImage
> with type GL_UNSIGNED_INT_10F_11F_11F_REV should be
> GL_INVALID_OPERATION. As glGetTexImage in OpenGL 4.2 Reference Pages:
> 
> On 12/13/2011 10:18 PM, Zhao, Jian J wrote:
> >> -----Original Message-----
> >> From: Brian Paul [mailto:brianp at vmware.com]
> >> Sent: Tuesday, December 13, 2011 9:28 PM
> >> To: Zhao, Jian J
> >> Cc: piglit at lists.freedesktop.org
> >> Subject: Re: [Piglit] [PATCH] Add test case on error check on
> glGetTexImage
> >> with type GL_UNSIGNED_INT_10F_11F_11F_REV should be
> >> GL_INVALID_OPERATION. As glGetTexImage in OpenGL 4.2 Reference
> Pages:
> >>
> >> On 12/12/2011 10:47 PM, jian.j.zhao at intel.com wrote:
> >>> From: Jian Zhao<jian.j.zhao at intel.com>
> >>>
> >>> ---
> >>>    tests/general/CMakeLists.gl.txt |    1 +
> >>>    tests/general/getteximage.c     |   88
> >> +++++++++++++++++++++++++++++++++++++++
> >>
> >> The test should be renamed to be more specific about what it does.
> >> getteximage.c is pretty generic.
> >
> > OK. Is getteximage_arguments_mismatch_error.c OK? :)
> 
> Since you're testing an aspect of the GL_EXT_packed_float extension, I think
> it should be something like
> "tests/spec/ext_packed_float/getteximage_error_check.c"

Yes. I agree. I will update it and resend it right now. Thanks!

Best regards
ZhaoJian

> 
> Otherwise, the updated patch looks good.
> 
> -Brian