[Piglit] [PATCH] Add test case for glClearBuffer in mixed format color buffers Test creates single FBO with multiple format color attachments and clears the buffers using glClearBuffer functions
Anuj Phogat
anuj.phogat at gmail.com
Mon Dec 19 11:55:40 PST 2011
Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
---
This is an updadted patch based on review comments by Ian Romanick.
Let me know if i can still make it better.
tests/all.tests | 1 +
tests/spec/gl-3.0/api/CMakeLists.gl.txt | 1 +
tests/spec/gl-3.0/api/clearbuffer-mixed-format.c | 266 ++++++++++++++++++++++
3 files changed, 268 insertions(+), 0 deletions(-)
create mode 100644 tests/spec/gl-3.0/api/clearbuffer-mixed-format.c
diff --git a/tests/all.tests b/tests/all.tests
index b713de0..11e3be1 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -808,6 +808,7 @@ add_concurrent_test(gl30, 'clearbuffer-depth')
add_concurrent_test(gl30, 'clearbuffer-depth-stencil')
add_concurrent_test(gl30, 'clearbuffer-invalid-drawbuffer')
add_concurrent_test(gl30, 'clearbuffer-invalid-buffer')
+add_concurrent_test(gl30, 'clearbuffer-mixed-format')
add_concurrent_test(gl30, 'clearbuffer-stencil')
add_concurrent_test(gl30, 'getfragdatalocation')
gl30['minmax'] = concurrent_test('gl-3.0-minmax')
diff --git a/tests/spec/gl-3.0/api/CMakeLists.gl.txt b/tests/spec/gl-3.0/api/CMakeLists.gl.txt
index 466ffeb..57879ff 100644
--- a/tests/spec/gl-3.0/api/CMakeLists.gl.txt
+++ b/tests/spec/gl-3.0/api/CMakeLists.gl.txt
@@ -17,6 +17,7 @@ add_executable (clearbuffer-depth clearbuffer-common.c clearbuffer-depth.c)
add_executable (clearbuffer-depth-stencil clearbuffer-common.c clearbuffer-depth-stencil.c)
add_executable (clearbuffer-invalid-drawbuffer clearbuffer-invalid-drawbuffer.c)
add_executable (clearbuffer-invalid-buffer clearbuffer-invalid-buffer.c)
+add_executable (clearbuffer-mixed-format clearbuffer-common.c clearbuffer-mixed-format.c)
add_executable (clearbuffer-stencil clearbuffer-common.c clearbuffer-stencil.c)
add_executable (getfragdatalocation getfragdatalocation.c)
diff --git a/tests/spec/gl-3.0/api/clearbuffer-mixed-format.c b/tests/spec/gl-3.0/api/clearbuffer-mixed-format.c
new file mode 100644
index 0000000..a67f2f1
--- /dev/null
+++ b/tests/spec/gl-3.0/api/clearbuffer-mixed-format.c
@@ -0,0 +1,266 @@
+/* Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/*
+ * \file clearbuffer-mixed-format.c
+ * Verify clearing mixed format color buffers with glClearBuffer functions
+ *
+ * This test works by generating several mixed format color render buffer
+ * objects and attempting to clear those buffers by calling glClearBufferfv,
+ * glClearBufferiv or glClearBufferuiv
+ * Verify:
+ * - glClearBufferfv should clear the float color buffer to a desired
+ * float value
+ *
+ * - glClearBufferuiv should clear the unsigned int color buffer to a
+ * desired unsigned integer value
+ *
+ * - glClearBufferiv should clear the integer color buffer to a desired
+ * integer value
+ *
+ * - No error should be generated for using glClearBufferuiv or
+ * glClearBufferiv on a float colors buffer or using glClearBufferfv
+ * on a integer color buffers
+ *
+ * \author Anuj Phogat
+ */
+
+#include "piglit-util.h"
+#include "clearbuffer-common.h"
+
+#define COUNT ARRAY_SIZE(test_vectors)
+
+ static const float fcolor[4][4] = {
+ { 0.5, 0.3, 0.7, 0.0 },
+ { 0.8, 0.0, 0.2, 1.0 },
+ { 1.2, -2.9, 0.2, 5.8 },
+ { 0.5, 2.5, -5.2, 1.0 } };
+
+ static const unsigned int uicolor[3][4] = {
+ { 10, 90, 100, 150 },
+ { 100, 190, 200, 15 },
+ { 15, 25, 20, 15 } };
+
+ static const int icolor[3][4] = {
+ { -10, -90, 100, 15 },
+ { 100, 190, 200, -15 },
+ { -50, -50, -50, 50 } };
+
+ static const struct {
+ GLenum rb_format;
+ GLenum rp_format;
+ GLenum type;
+ GLvoid *clear_color;
+ } test_vectors[] = {
+ /* GL_RGBA8, GL_RGBA16 clamps the color vaues to [0, 1] */
+ { GL_RGBA8, GL_RGBA,
+ GL_FLOAT, (GLvoid *)fcolor[0] },
+ { GL_RGBA16, GL_RGBA,
+ GL_FLOAT, (GLvoid *)fcolor[1] },
+
+ /* GL_RGBA16F, GL_RGBA32F doesn't clamp color values to [0, 1] */
+ { GL_RGBA16F, GL_RGBA,
+ GL_FLOAT, (GLvoid *)fcolor[2] },
+ { GL_RGBA32F, GL_RGBA,
+ GL_FLOAT, (GLvoid *)fcolor[3] },
+
+ /* Integer formats */
+ { GL_RGBA8UI, GL_RGBA_INTEGER,
+ GL_UNSIGNED_INT, (GLvoid *)uicolor[0] },
+ { GL_RGBA32UI, GL_RGBA_INTEGER,
+ GL_UNSIGNED_INT, (GLvoid *)uicolor[2] },
+
+ { GL_RGBA16I, GL_RGBA_INTEGER,
+ GL_INT, (GLvoid *)icolor[1] },
+ { GL_RGBA32I, GL_RGBA_INTEGER,
+ GL_INT, (GLvoid *)icolor[2] },
+ };
+
+
+GLuint
+generate_fbo(void)
+{
+ GLuint fb;
+ GLuint rb[COUNT];
+ GLuint i;
+ GLenum status;
+
+ /* Generate a frame buffer object */
+ glGenFramebuffers(1, &fb);
+ glBindFramebuffer(GL_FRAMEBUFFER, fb);
+ /* Generate renderbuffers */
+ glGenRenderbuffers(COUNT, rb);
+
+ for(i = 0; i < COUNT; i++) {
+ glBindRenderbuffer(GL_RENDERBUFFER, rb[i]);
+ /* Buffer storage is allocated based on render buffer format */
+ glRenderbufferStorage(GL_RENDERBUFFER,
+ test_vectors[i].rb_format,
+ piglit_width,
+ piglit_height);
+ /* Attach the render buffer to a color attachment */
+ glFramebufferRenderbuffer(GL_FRAMEBUFFER,
+ GL_COLOR_ATTACHMENT0 + i,
+ GL_RENDERBUFFER,
+ rb[i]);
+
+ piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+ }
+
+ status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
+ if (status != GL_FRAMEBUFFER_COMPLETE) {
+ fprintf(stderr,
+ "Framebuffer with color"
+ "attachment was not complete: 0x%04x\n",
+ status);
+ piglit_report_result(PIGLIT_FAIL);
+ }
+
+ if (status == GL_FRAMEBUFFER_UNSUPPORTED) {
+ glDeleteRenderbuffers(COUNT, rb);
+ glDeleteFramebuffers(1, &fb);
+ return 0;
+ }
+ /* All the color render buffers are cleared to default RGBA
+ * (0, 0, 0, 0) color
+ */
+ for (i = 0; i < COUNT; i++) {
+ glDrawBuffer(GL_COLOR_ATTACHMENT0 + i);
+ glClear(GL_COLOR_BUFFER_BIT);
+ }
+ piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+ return fb;
+}
+
+void piglit_init(int argc, char **argv)
+{
+ GLint err;
+ GLuint fb;
+ bool pass = true;
+ int i, j;
+
+ piglit_require_gl_version(30);
+ fb = generate_fbo();
+ if (fb == 0) {
+ if (!piglit_automatic) {
+ printf("Skipping framebuffer with color"
+ " attachments\n");
+ }
+ }
+ if (!piglit_automatic)
+ printf("Created framebuffer with a color"
+ " attachments\n");
+
+ for (i = 0; i < COUNT; i++) {
+
+ /* Set the draw buffer and read buffer */
+ glDrawBuffer(GL_COLOR_ATTACHMENT0 + i);
+ glReadBuffer(GL_COLOR_ATTACHMENT0 + i);
+
+ /* Clear the color buffer to a unique color */
+ switch (test_vectors[i].type) {
+
+ /* Float buffer types */
+ case GL_FLOAT:
+ glClearBufferfv(GL_COLOR,
+ i,
+ (GLfloat *)test_vectors[i].clear_color);
+ break;
+
+ /* Signed/unsigned integer buffer types */
+ case GL_INT:
+ glClearBufferiv(GL_COLOR,
+ i,
+ (GLint *)test_vectors[i].clear_color);
+ break;
+
+ case GL_UNSIGNED_INT:
+ glClearBufferuiv(GL_COLOR,
+ i,
+ (GLuint *)test_vectors[i].clear_color);
+
+ break;
+ }
+ /* Test the pixel values of color buffer against
+ * expected color values
+ */
+ pass = pass &&
+ probe_rect_color(0,
+ 0,
+ piglit_width,
+ piglit_height,
+ test_vectors[i].rp_format,
+ test_vectors[i].type,
+ test_vectors[i].clear_color);
+
+ /* Verify that glClearBuffer[uif]v functions only modify the
+ * color data of current draw buffer. Other color buffers stay
+ * uneffected
+ */
+ for (j = 0; j < i; j++)
+ {
+ /* Set the read buffer */
+ glReadBuffer(GL_COLOR_ATTACHMENT0 + j);
+ /* Test the pixel values of color buffer against
+ * expected color values
+ */
+ pass = pass &&
+ probe_rect_color(0,
+ 0,
+ piglit_width, piglit_height,
+ test_vectors[j].rp_format,
+ test_vectors[j].type,
+ test_vectors[j].clear_color);
+ }
+ }
+
+ /* No GL error should be generated for clearing integer buffers using
+ * glClearBufferfv or clearing float buffers with glClearBufferiv/
+ * glClearBufferuiv. But the result of ClearBuffer is undefined.
+ * Reference: OpenGL 3.0 specification section 4.2.3 "Clearing the
+ * Buffers"
+ */
+ for (i = 0; i < COUNT; i++) {
+ glDrawBuffer(GL_COLOR_ATTACHMENT0 + i);
+
+ glClearBufferuiv(GL_COLOR,
+ i,
+ uicolor[0]);
+ glClearBufferiv(GL_COLOR,
+ i,
+ icolor[0]);
+ glClearBufferfv(GL_COLOR,
+ i,
+ fcolor[0]);
+
+ err = glGetError();
+ if (err != GL_NO_ERROR) {
+ piglit_get_gl_error_name(err);
+ pass = false;
+ }
+ }
+ /* Delete framebuffer object */
+ glDeleteFramebuffers(1, &fb);
+ piglit_check_gl_error(GL_NO_ERROR, PIGLIT_FAIL);
+ piglit_present_results();
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
--
1.7.7.4
More information about the Piglit
mailing list